[jdk8u-dev] RFR: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

[Robert Toyonaga]

On Fri, 3 May 2024 20:52:00 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685
> 
> This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.
> 
> This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)
> 
> Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.

Commenting so that this won't be closed due to inactivity. Could someone please help review this? I didn't have to make any additional changes, the backport was applied cleanly.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/490#issuecomment-2147535954