[jdk8u-dev] RFR: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

[Thomas Stuefe]

On Fri, 3 May 2024 20:52:00 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685
> 
> This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.
> 
> This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)
> 
> Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.

Hi Robert, what's wrong with the red GHA tests?

Besides that, please make sure, especially for a PR that has been dormant for a longer time, that you merge in the latest changes from upstream (we prefer merging over rebasing for a PR that is being discussed). Then the GHAs should be green, or the reds explainable. Then you can apply for approval (slash approval).

The fix itself looks good.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/490#issuecomment-2147961955