[jdk8u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1

[fitzsim]

On Tue, 4 Jun 2024 14:12:53 GMT, fitzsim <duke at openjdk.org> wrote:

> 8315117: Update Zlib Data Compression Library to Version 1.3
> 8326351: Update the Zlib version in THIRD_PARTY_README to 1.3.1
> 
> Backport-of: 6aa721649d870354a79c3508343b14222e0edcfb
> 
> I am filing this pull request now mainly to register that I am working on this backport.  Some of the sanity checks have already failed on package download issues; I will try re-running them and otherwise investigating how to fix them.

Other than path differences and license changes in `zlib.md` in `11` versus `THIRD_PARTY_README` in `8`, the changes applied cleanly.

I guess the Debian `s390x` and `ppc64le` sanity check jobs could be updated from `buster` to `bullseye`, since these URLs 404:

http://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages
http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages

whereas these exist:

http://httpredir.debian.org/debian/dists/bullseye/main/binary-s390x/Packages.gz
http://httpredir.debian.org/debian/dists/bullseye/main/binary-ppc64el/Packages.gz

For the Windows `x86` failures, this URL 404s:

https://debian.fmi.uni-sofia.bg/~aangelov/VS2010Express1.iso

This seems like a good substitute:

https://archive.org/download/vs-2010-express-1/VS2010Express1.iso

I confirmed the SHA256 hash matches the value expected by the environment variable in the script, `a9d5dcdf55e539a06547a8ebbc63d55dc167113e09ee9e42096ab9098313039b`.

The archive.org download is slow, and 700 MiB is a lot to pull from archive.org on every job run.  So caching this file somewhere closer (network-wise) to the builder would be nice.  However, from my reading about GHA caches, they are per-branch, so the file would be redownloaded once per pull request anyway.

The same new missing/out-of-date certificate failure happened on `Linux x64 (jdk/tier1)`, `Linux x86 (jdk/tier1)`, `Windows x64 (jdk/tier1)`, and `macOS x64 (jdk/tier1)`, but this seems unrelated to the backport:

`security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1`

Darn, I forgot to change the PR title to "Backport 6aa721649d870354a79c3508343b14222e0edcfb"; I just changed it now.  I will see if the bot notices and adds the "backport" tag, otherwise I will look into the SKARA backport command, or look at labelling it manually.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2147678095
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2147690286
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2147775762
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2147782569
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2147831473
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2147909993