[jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64 zero build is not accurate.

[Andrew John Hughes]

On Sun, 28 Apr 2024 06:48:33 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> I'd like to backport this patch to jdk8u. `common/autoconf/platform.m4` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.
> 
> A native build on LoongArch hardware is tested.
> 
> Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html
> 
> 
> $ ./build/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_412"
> OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
> OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)
> 
> 
> Loongnix Desktop:
> 
> 
> $ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_422-internal"
> OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
> OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)
> 
> 
> The risk of the downport is low.
> 
> Thanks,
> Leslie Zhai

The PR title should be "Backport 725ec0ce1b463b21cd4c5287cf4ccbee53ec7349" so this is correctly recognised as a backport.

I agree with @mirabilos that the `platform.m4` change is unneeded. That block is only needed where `ZERO_ARCHDEF` and ` OPENJDK_TARGET_CPU_LEGACY_LIB`  differ e.g. `ppc` vs. `ppc32` or `x86_64` vs. `amd64`. The `ppc64` one is also unnecessary but I wouldn't change this at this juncture.

I'm also leaning towards thinking we should file this against https://github.com/openjdk/jdk8u to get it in as a fix for July rather than waiting for October. The risk to other architectures should be zero, while this makes the new platform build. Sorry for not getting to this earlier so it would go in before rampdown. Thoughts?

Did the original version build on some LoongArch64 platforms? I'm wondering how this got through the original testing.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/489#pullrequestreview-2113083092