[jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64 zero build is not accurate.

[Leslie Zhai]

On Sun, 28 Apr 2024 16:07:36 GMT, mirabilos <duke at openjdk.org> wrote:

>> Hi,
>> 
>> I'd like to backport this patch to jdk8u. `common/autoconf/platform.m4` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.
>> 
>> A native build on LoongArch hardware is tested.
>> 
>> Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html
>> 
>> 
>> $ ./build/images/j2sdk-image/bin/java -version
>> openjdk version "1.8.0_412"
>> OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
>> OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)
>> 
>> 
>> Loongnix Desktop:
>> 
>> 
>> $ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
>> openjdk version "1.8.0_422-internal"
>> OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
>> OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)
>> 
>> 
>> The risk of the downport is low.
>> 
>> Thanks,
>> Leslie Zhai
>
> common/autoconf/platform.m4 line 384:
> 
>> 382:   # ZERO_ARCHDEF is used to enable architecture-specific code
>> 383:   case "${OPENJDK_TARGET_CPU}" in
>> 384:     loongarch64)  ZERO_ARCHDEF=LOONGARCH64 ;;
> 
> This is not necessary, line 390 already does that.

But the line 390 is for x86, isn't it? Please point out my fault!

Thanks,
Leslie Zhai

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/489#discussion_r1637329052