[jdk8u-dev] RFR: 8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]

[Kazuhisa Takakuri]

On Thu, 7 Dec 2023 00:23:04 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8320964
>>  - Fix copyright year and @bug
>>  - Fix Native2AsciiTests.sh
>
> The tool and its tests are removed in 11u and later by JDK-8074431 so this is only applicable to 8u. The incorrect `\\r` was still in place when removed.
> 
> Is this specific to Japanese? It seems like it would fail with any Windows output containing carriage returns. Is it just that the Japanese character set needs conversion from native to ASCII?
> 
> The fix itself looks good. The copyright year needs to be bumped and the bug ID added to the `@bug` line. It will probably need to be split onto a new line due to the length; see `jdk/test/java/util/Locale/LocaleTest.java` for an example of this.

@gnu-andrew 
Could you please check for added fixes?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2109852427