[jdk8u-dev] RFR: 8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]
Andrew John Hughes
andrew at openjdk.org
Wed May 22 15:46:11 UTC 2024
On Mon, 8 Apr 2024 12:28:29 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:
>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into 8320964
> - Fix copyright year and @bug
> - Fix Native2AsciiTests.sh
Could you indent the new bug ID as in [VerifyCACerts.java](https://github.com/openjdk/jdk8u/blob/master/jdk/test/sun/security/lib/cacerts/VerifyCACerts.java) (i.e. so the '8' in the new ID lines up with the '4' in the one above)? Sorry for providing you with a bad example at first in `LocaleTest.java`
With that change, this should be good to go.
-------------
Changes requested by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/400#pullrequestreview-2071663472
More information about the jdk8u-dev
mailing list