[jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating [v4]

[Severin Gehwolf]

On Mon, 13 May 2024 12:58:21 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - correcting comment for clean build
>  - Correcting comments for clean backport
>  - Backport  1b925183894778acce8aff4c101f67af98f0097f
>    
>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

The test fails:


/disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
            if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
                 ^
  symbol:   variable Arrays
  location: class TestIBMBugs
1 error
result: Failed. Compilation failed: Compilation failed


Adding the import should fix it.

Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!

-------------

Changes requested by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/476#pullrequestreview-2057922151