[jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating [v4]

[Pratiksha Sawant]

On Wed, 15 May 2024 12:51:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>>  - correcting comment for clean build
>>  - Correcting comments for clean backport
>>  - Backport  1b925183894778acce8aff4c101f67af98f0097f
>>    
>>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>
>
> The test fails:
> 
> 
> /disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
>             if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
>                  ^
>   symbol:   variable Arrays
>   location: class TestIBMBugs
> 1 error
> result: Failed. Compilation failed: Compilation failed
> 
> 
> Adding the import should fix it.
> 
> Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!

@jerboaa,
I have fixed the compilation error and GHAs are enabled on this repo.
IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm

Attaching test evidences for the bug fix with before and after screenshots.

Before fix:
<img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/8773d3a1-a185-4806-9b7e-b585cddfb5da">

After fix:
<img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/f4d99e66-16bf-41b4-b665-365f8301b26a">

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114292841