[jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating [v4]

Pratiksha Sawant duke at openjdk.org
Thu May 16 11:10:08 UTC 2024


On Thu, 16 May 2024 08:40:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @jerboaa,
>> I have fixed the compilation error and GHAs are enabled on this repo.
>> IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm
>> 
>> Attaching test evidences for the bug fix with before and after screenshots.
>> 
>> Before fix:
>> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/8773d3a1-a185-4806-9b7e-b585cddfb5da">
>> 
>> After fix:
>> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/f4d99e66-16bf-41b4-b665-365f8301b26a">
>
>> I have fixed the compilation error and GHAs are enabled on this repo.
> 
> Please merge lastest master into your branch, which should make the certinga CA tests failure go away.

@jerboaa,
There is still 1 pre-test failing that is because these below packages doesn't exist at this location. 
- https://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages
- https://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages

Is the PR good to go for maintainer approval?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114935413


More information about the jdk8u-dev mailing list