[jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating [v4]
Severin Gehwolf
sgehwolf at openjdk.org
Thu May 16 08:43:07 UTC 2024
On Thu, 16 May 2024 07:41:59 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:
>> The test fails:
>>
>>
>> /disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
>> if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
>> ^
>> symbol: variable Arrays
>> location: class TestIBMBugs
>> 1 error
>> result: Failed. Compilation failed: Compilation failed
>>
>>
>> Adding the import should fix it.
>>
>> Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!
>
> @jerboaa,
> I have fixed the compilation error and GHAs are enabled on this repo.
> IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm
>
> Attaching test evidences for the bug fix with before and after screenshots.
>
> Before fix:
> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/8773d3a1-a185-4806-9b7e-b585cddfb5da">
>
> After fix:
> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/f4d99e66-16bf-41b4-b665-365f8301b26a">
@psawant19 Thanks. Please also show that the `sun/nio/cs` jtreg tests are passing.
> I have fixed the compilation error and GHAs are enabled on this repo.
Please merge lastest master into your branch, which should make the certinga CA tests failure go away.
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114507070
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114514950
More information about the jdk8u-dev
mailing list