[jdk8u-dev] RFR: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp

Martin Balao mbalao at openjdk.org
Thu Sep 12 04:29:42 UTC 2024


Hi,

I'd like to propose an 8u backport of 8233364.

The 11u backport of 8233364 does not apply cleanly or requires changes because of the following reasons:

  * Context differences in the change due to the absence of 8182299 in 8u.

  * 8181449 is not in 8u, so an include of "utilities/debug.hpp" would need to be added for STATIC_ASSERT to be available in utilities/globalDefinitions.hpp. However, this generates a dependency issue and we would need to backport the 8181449 enhancement anyways. 8181449 is a big change and would be too risky for 8u. I added the assertion using the old style.

  * 8u does not have 8148244 (gtest).

All tests in the hotspot/test/compiler/c1 category passed.

Thanks,
Martin.-

-------------

Commit messages:
 - Backport 89e3782f218a54c91cbab9f06e75825b90dd2fb7

Changes: https://git.openjdk.org/jdk8u-dev/pull/577/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=577&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8233364
  Stats: 50 lines in 2 files changed: 36 ins; 4 del; 10 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/577.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/577/head:pull/577

PR: https://git.openjdk.org/jdk8u-dev/pull/577


More information about the jdk8u-dev mailing list