[jdk8u-dev] RFR: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp

[Severin Gehwolf]

On Thu, 12 Sep 2024 04:24:35 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to propose an 8u backport of 8233364.
> 
> The 11u backport of 8233364 does not apply cleanly or requires changes because of the following reasons:
> 
>   * Context differences in the change due to the absence of 8182299 in 8u.
> 
>   * 8181449 is not in 8u, so an include of "utilities/debug.hpp" would need to be added for STATIC_ASSERT to be available in utilities/globalDefinitions.hpp. However, this generates a dependency issue and we would need to backport the 8181449 enhancement anyways. 8181449 is a big change and would be too risky for 8u. I added the assertion using the old style.
> 
>   * 8u does not have 8148244 (gtest).
> 
> All tests in the hotspot/test/compiler/c1 category passed.
> 
> Thanks,
> Martin.-

This looks OK to me. Maybe @adinn or @theRealAph could take a look as well?

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/577#pullrequestreview-2300603641