[jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties [v3]

[Andrew John Hughes]

On Wed, 20 Aug 2025 16:29:55 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Add missing properties for the j2gss.dll and sspi_bridge.dll files
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add CheckWindowsProperty test

It looks like what happened here is [JDK-8199639](https://bugs.openjdk.org/browse/JDK-8199639) went into 11u just a month before the original [JDK-8345358](https://bugs.openjdk.org/browse/JDK-8345358) that was backported to 8u. The 8199639 change created `SetupJdkLibrary` which was converted to `SetupNativeCompilation`in the backport. What we should have caught is that this is not a 1-to-1 replacement. `SetupJdkLibrary` is a wrapper around `SetupNativeCompilation` which - you've guessed it - sets the `RC_FLAGS` before calling `SetupNativeCompilation`.

I might look and see if it's feasible to backport that change, so we don't miss this again in future, but this minimal fix will solve the current issue.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/611#pullrequestreview-3170395081