RFR #2 (M) 8148146: Integrate new internal Unsafe entry points, and basic intrinsic support for VarHandles
Volker Simonis
volker.simonis at gmail.com
Tue Feb 23 14:19:16 UTC 2016
Hi Aleksey,
sorry for the delay. Your change builds and runs fine on ppc64.
Still haven't had time to look at the possible optimizations and
intrinsics on ppc64 but I think that can and should be done in a
follow up change.
So from my side you can go ahead and push.
Regards,
Volker
On Thu, Feb 18, 2016 at 8:47 AM, Volker Simonis
<volker.simonis at gmail.com> wrote:
> On Wed, Feb 17, 2016 at 8:42 PM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com> wrote:
>> On 02/17/2016 10:16 PM, Vladimir Kozlov wrote:
>>> In general it looks good to me.
>>
>> Thanks Vladimir!
>>
>>> My main question is about implementation of new functionality on
>>> other platforms. When it will be done? Yes, it works now because you
>>> have guard match_rule_supported(). But we usually do implementation
>>> on platforms at least as separate RFE. What is your plan?
>>
>> We have multiple subtasks for AArch64, SPARC and Power under VarHandles
>> umbrella:
>> https://bugs.openjdk.java.net/browse/JDK-8080588
>>
>> Hopefully we will address them after/concurrently-with the bulk of
>> VarHandles changes settle into mainline. But we need to get some basic
>> code in mainline to build on.
>>
>>
>>> SAP guys should also test it on PPC64.
>>
>> Volker, Goetz, I would appreciate if you can give it a spin!
>>
>
> Sorry, I only saw this thread yesterday. I'll start now right away
> with looking into it and testing it on ppc64.
>
> Regards,
> Volker
>
>>
>>> What test/compiler/unsafe/generate-unsafe-tests.sh is for? It is not
>>> used by regression testing as far as I see.
>>
>> The script (re)generates the tests from the template, and is supposed to
>> be run manually when test template had changed. The
>> test/compiler/unsafe/ tests you see in the webrev were generated by that
>> script.
>>
>>> And please, push it into hs-comp for nightly testing.
>>
>> That's was the plan, I should have said that from the beginning.
>>
>> Cheers,
>> -Aleksey
>>
More information about the jdk9-dev
mailing list