RFR: Prepare jemmy for adoptopenjdk build and deploy

Patrick Reinhart patrick at reini.net
Wed May 16 19:14:54 UTC 2018


Just wanted to know if there is anything I can do further before that
change could be commited?

-Patrick

Am 10.05.2018 um 18:38 schrieb Patrick Reinhart:
> Hi Shura,
>
> There is no requirement to have @author tags in the source code. I only removed the email addresss and those characters failing to pass the Javadoc generation.
>
> For the rest of the code the main changes contain removal of Javadoc parts, that did only contained @param/@return tags with no futher content.
>
> When I started together with Marcus, we tried to complete the incomplete @param values. If there where Jacadoc comments with partial content, I added „todo javadoc“ to those @param/@return tags that where missing or where only partiallly available. The intention was to may going over it later and fill those missing parts in. Apart from this there where no code changes done exept using some diamond operators instead of the extended generics definition. Also the main changes where done within the root pom.xml file adding the licence/scm and authors section in order to pass the maven central requirements.
>
> Hope the answered your questions so far. 
>
> -Patrick 
>
>
>> Am 10.05.2018 um 17:23 schrieb Alexandre (Shura) Iline <alexandre.iline at oracle.com>:
>>
>> Patrick,
>>
>> It is definitely not common to use @author tag in openjdk. Is that required for Maven?
>>
>> The patch also seem to be updating some javadoc (core/JemmyCore/src/org/jemmy/input/CharBindingMap.java), which is a very useful thing to do, only I am now wondering what else this patch is changing.
>>
>> Could you quickly summarize?
>>
>> I am sorry if you did this before and I missed it.
>>
>> Shura
>>




More information about the jemmy-dev mailing list