RFR: 7903202: enable macOS CI checks
Jorn Vernee
jvernee at openjdk.java.net
Tue May 31 13:50:23 UTC 2022
On Mon, 30 May 2022 08:36:51 GMT, Denys Makogon <duke at openjdk.java.net> wrote:
> This adjustment modifies the build config by introducing
> strategy matrix in order to enable builds from both Ubuntu and macOS.
This looks good to me. Just have to wait for the OCA check.
Also, I think you actually want `/covered` instead of `/signed`.
.github/workflows/test.yml line 27:
> 25: - os: macos-latest
> 26: TARGET: apple-darwin
> 27: JAVA19_HOME: /tmp/deps/jdk-19/jdk-19.jdk/Contents/Home
Both of these test runs now show up as part of the same job called `linux-x64`. I suggest splitting this into 3 jobs instead:
1. a job that does all the setup.
2. a job for linux testing
3. a job for mac testing
Where both 2 and 3 depend on 1. (see for instance how the JDK workflow achieves this using job outputs: https://github.com/openjdk/jdk/blob/master/.github/workflows/submit.yml#L149)
'Testing' would include the 'Build Jextract' and 'Run Tests' steps.
.github/workflows/test.yml line 39:
> 37: run: |
> 38: mkdir -p deps/jtreg
> 39: mkdir -p /tmp/deps
Looks like you moved `deps` to `/tmp`. Why is that?
Also, should the `deps/jtreg` also be moved to `tmp` in that case?
-------------
Marked as reviewed by jvernee (no project role).
PR: https://git.openjdk.java.net/jextract/pull/45
More information about the jextract-dev
mailing list