RFR: 7903202: enable macOS CI checks
Denys Makogon
duke at openjdk.java.net
Tue May 31 13:50:24 UTC 2022
On Mon, 30 May 2022 10:46:58 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> .github/workflows/test.yml line 27:
>>
>>> 25: - os: macos-latest
>>> 26: TARGET: apple-darwin
>>> 27: JAVA19_HOME: /tmp/deps/jdk-19/jdk-19.jdk/Contents/Home
>>
>> Both of these test runs now show up as part of the same job called `linux-x64`. I suggest splitting this into 3 jobs instead:
>> 1. a job that does all the setup.
>> 2. a job for linux testing
>> 3. a job for mac testing
>>
>> Where both 2 and 3 depend on 1. (see for instance how the JDK workflow achieves this using job outputs: https://github.com/openjdk/jdk/blob/master/.github/workflows/submit.yml#L149)
>>
>> 'Testing' would include the 'Build Jextract' and 'Run Tests' steps.
>
> Actually, it looks like that might not be that easy, since the prerequisites also have to pick a platform to run on.
>
> In that case, I suggest just changing the name of the job to be something like `Build & Test`.
At first, i thought about replacing one config with per-platform. The only foreseeable scenario with a per-platform config - is when we'd need to add Windows. Because eventually, we'd have to release a binary for Win as well. But as of now, one config for both Debian and macOS is a good-to-go solution.
-------------
PR: https://git.openjdk.java.net/jextract/pull/45
More information about the jextract-dev
mailing list