RFR: 7903587: Revisit inlining of struct layouts into other layouts/descriptors [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Dec 12 16:09:00 UTC 2023


On Tue, 12 Dec 2023 15:22:05 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move packed test in new subfolder
>
> src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 285:
> 
>> 283:     private String alignIfNeeded(String layoutPrefix, long align, long expectedAlign) {
>> 284:         return align > expectedAlign ?
>> 285:                 STR."\{layoutPrefix}.withByteAlignment(\{expectedAlign})" :
> 
> We never take the branch that adjusts the alignment here.

Is this fixed with the test I forgot to add? :-)

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/157#discussion_r1424234005


More information about the jextract-dev mailing list