RFR: 7903587: Revisit inlining of struct layouts into other layouts/descriptors [v3]

Jorn Vernee jvernee at openjdk.org
Tue Dec 12 17:26:45 UTC 2023


On Tue, 12 Dec 2023 16:06:10 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 285:
>> 
>>> 283:     private String alignIfNeeded(String layoutPrefix, long align, long expectedAlign) {
>>> 284:         return align > expectedAlign ?
>>> 285:                 STR."\{layoutPrefix}.withByteAlignment(\{expectedAlign})" :
>> 
>> We never take the branch that adjusts the alignment here.
>
> Is this fixed with the test I forgot to add? :-)

Yes

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/157#discussion_r1424342169


More information about the jextract-dev mailing list