RFR: 7903917: Changes needed for jdk23-based makefile build

Jorn Vernee jvernee at openjdk.org
Wed Dec 18 16:27:52 UTC 2024


On Tue, 17 Dec 2024 16:35:00 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Changes necessary to bump the supported version to JDK 23.
> Passes tier 1.
> 
> Note: This PR will not be integrated before https://github.com/openjdk/jextract/pull/264 as the removal of `--enable-preview` is needed.

make/Build.gmk line 50:

> 48: 	$(MKDIR) -p $(BUILD_CLASSES_DIR)/org/openjdk/jextract/impl
> 49: 	$(FIXPATH) $(PANAMA_JAVA_HOME)/bin/javac \
> 50: 	    --release=23 \

I suppose once we drop `--enable-preview` the `--release flag` can also be dropped, and will just default to the version of the JDK we are building with. This is fine as the same JDK is used to create the jextract runtime image.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/265#discussion_r1890516833


More information about the jextract-dev mailing list