RFR: 7903917: Changes needed for jdk23-based makefile build [v2]

Nizar Benalla nbenalla at openjdk.org
Wed Dec 18 17:43:27 UTC 2024


On Wed, 18 Dec 2024 16:25:16 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove --release flag
>
> make/Build.gmk line 50:
> 
>> 48: 	$(MKDIR) -p $(BUILD_CLASSES_DIR)/org/openjdk/jextract/impl
>> 49: 	$(FIXPATH) $(PANAMA_JAVA_HOME)/bin/javac \
>> 50: 	    --release=23 \
> 
> I suppose once we drop `--enable-preview` the `--release` flag can also be dropped, and will just default to the version of the JDK we are building with. This is fine as the same JDK is used to create the jextract runtime image.

Fixed in [5380106](https://github.com/openjdk/jextract/pull/265/commits/53801062000157c03e8ed0d8066dc8efceca161f) but it seems like we are bound to have a conflict after you integrate anyway, I tried a few things and would always end up with a conflict.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/265#discussion_r1890616126


More information about the jextract-dev mailing list