RFR: 7903674: jextract should ignore non-enum constants inside enum [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Feb 20 14:06:04 UTC 2024


On Tue, 20 Feb 2024 13:37:33 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> * checking cursor kind of child cursor to be CursorKind.EnumConstantDecl. 
>> * Piggybacking to fix similar check of record child element kinds to be CursorKind.FieldDecl.  
>> * Added null check for createTree return value in collectNestedTypes method as well.
>> * In addition to jextract tests, I ran all samples on Mac OS. All fine with this change. Also, ran jextract script for Mac OS from  https://github.com/manuelbl/JavaDoesUSB.git.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reduce the diffs for this patch.

Looks good to me - please rename the test as @JornVernee suggested

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jextract/pull/221#pullrequestreview-1890512396


More information about the jextract-dev mailing list