RFR: 7903674: jextract should ignore non-enum constants inside enum [v4]
Maurizio Cimadamore
mcimadamore at openjdk.org
Tue Feb 20 14:35:03 UTC 2024
On Tue, 20 Feb 2024 14:11:19 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Isn't that the whole point of the fix? (e.g. skipping nulls when a "weird" cursor shows up)
>
> I thought the `child.kind() == CursorKind.EnumConstantDecl` supersedes that.
>
> P.S. If `null`s are still possible at this point, it would be nice to have a test for that too.
Ah, I missed the new check for EnumConstantDecl. I don't think we can ever return a null in there. So, yes, the extra null check is redundant.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/221#discussion_r1495923086
More information about the jextract-dev
mailing list