RFR: 7903636: update jextract sample scripts for --source option removal [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jan 22 10:22:00 UTC 2024


On Mon, 22 Jan 2024 09:31:03 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> * removing --source option in scripts
>> * removing binary .class generating scripts (as normal scripts do compilation by javac anyway)
>> * removing unnecessary --enable-preview option in run scripts.
>> * updating gradle version to be the latest (8.5) so that we can use JDK 21 for gradle run itself.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   re-generated libjimage jextracted sources for the recent jextract changes.

gradle/wrapper/gradle-wrapper.properties line 3:

> 1: distributionBase=GRADLE_USER_HOME
> 2: distributionPath=wrapper/dists
> 3: distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip

I don't think these changes should be included?

samples/cblas/run.sh line 1:

> 1: time java --enable-native-access=ALL-UNNAMED \

why the `time` in front?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/189#discussion_r1461636625
PR Review Comment: https://git.openjdk.org/jextract/pull/189#discussion_r1461637666


More information about the jextract-dev mailing list