RFR: 7903636: update jextract sample scripts for --source option removal [v2]
Athijegannathan Sundararajan
sundar at openjdk.org
Mon Jan 22 10:51:00 UTC 2024
On Mon, 22 Jan 2024 10:18:26 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> re-generated libjimage jextracted sources for the recent jextract changes.
>
> gradle/wrapper/gradle-wrapper.properties line 3:
>
>> 1: distributionBase=GRADLE_USER_HOME
>> 2: distributionPath=wrapper/dists
>> 3: distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
>
> I don't think these changes should be included?
With that change, we can use JDK 21 to build jextract. Without that, we've to use JDK 18. Do we want this or not?
> samples/cblas/run.sh line 1:
>
>> 1: time java --enable-native-access=ALL-UNNAMED \
>
> why the `time` in front?
That was pre-existing code. Most likely we had it to have simple measure of execution speed of numeric libraries in the past. I can remove it if desired.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/189#discussion_r1461681935
PR Review Comment: https://git.openjdk.org/jextract/pull/189#discussion_r1461683127
More information about the jextract-dev
mailing list