RFR: 7903776: jextract generates uncompilable code when C identifier with the name from "java.lang" classes is used [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Jul 17 10:02:03 UTC 2024


On Wed, 17 Jul 2024 09:46:35 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Unqualified names are mangled by NameMangler. But it was complete (didn't include "Boolean"). For uniformity & future proof mangling all type names from "java.lang" package.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments.

Marked as reviewed by mcimadamore (Reviewer).

src/main/java/org/openjdk/jextract/impl/NameMangler.java line 361:

> 359:                 return true;
> 360:             }
> 361:         } catch (Exception ignored) {

Should we report something when using the verbose debug option?

-------------

PR Review: https://git.openjdk.org/jextract/pull/253#pullrequestreview-2182467233
PR Review Comment: https://git.openjdk.org/jextract/pull/253#discussion_r1680780935


More information about the jextract-dev mailing list