RFR: 7903776: jextract generates uncompilable code when C identifier with the name from "java.lang" classes is used [v2]

Athijegannathan Sundararajan sundar at openjdk.org
Wed Jul 17 12:41:03 UTC 2024


On Wed, 17 Jul 2024 09:59:48 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments.
>
> src/main/java/org/openjdk/jextract/impl/NameMangler.java line 361:
> 
>> 359:                 return true;
>> 360:             }
>> 361:         } catch (Exception ignored) {
> 
> Should we report something when using the verbose debug option?

Hmm. Not sure. May be bit noisy I think as exceptions will be thrown for many uppercase starting C identifiers (enum constants, #defines)

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/253#discussion_r1680978062


More information about the jextract-dev mailing list