RFR: 7903782: clang warnings and diagnostics below warning level should be logged as well [v2]

[Maurizio Cimadamore]

On Fri, 26 Jul 2024 13:08:07 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Parser logs clang warnings and diagnostics below warning level as well.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed ClangException. no bail out at the first clang error.
>   all clang errors, warnings and info (note) messages are printed to logger
>   by separate non-property key accepting methods of logger.

src/main/java/org/openjdk/jextract/impl/Logger.java line 90:

> 88:     }
> 89: 
> 90:     public void clangErr(Position pos, String msg) {

Optional: maybe this is just a single method that takes a clang diagnostic, and renders it appropriately?

src/main/java/org/openjdk/jextract/impl/Logger.java line 148:

> 146:     }
> 147: 
> 148:     public boolean hasClangWarnings() {

Optional: do we need this?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/255#discussion_r1693043669
PR Review Comment: https://git.openjdk.org/jextract/pull/255#discussion_r1693043893