RFR: 7903782: clang warnings and diagnostics below warning level should be logged as well [v2]

[Athijegannathan Sundararajan]

On Fri, 26 Jul 2024 13:13:09 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed ClangException. no bail out at the first clang error.
>>   all clang errors, warnings and info (note) messages are printed to logger
>>   by separate non-property key accepting methods of logger.
>
> src/main/java/org/openjdk/jextract/impl/Logger.java line 148:
> 
>> 146:     }
>> 147: 
>> 148:     public boolean hasClangWarnings() {
> 
> Optional: do we need this?

You're right. Even the earlier nWarnings and associated hasWarnings is unused. Will get rid of both warning counts and associated 'has' checker methods.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/255#discussion_r1693055293