RFR: 7903782: clang warnings and diagnostics below warning level should be logged as well [v2]

[Athijegannathan Sundararajan]

On Fri, 26 Jul 2024 13:12:59 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed ClangException. no bail out at the first clang error.
>>   all clang errors, warnings and info (note) messages are printed to logger
>>   by separate non-property key accepting methods of logger.
>
> src/main/java/org/openjdk/jextract/impl/Logger.java line 90:
> 
>> 88:     }
>> 89: 
>> 90:     public void clangErr(Position pos, String msg) {
> 
> Optional: maybe this is just a single method that takes a clang diagnostic, and renders it appropriately?

No clang API binding related stuff in Logger so far. Better to leave it at that I think.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/255#discussion_r1693059897