RFR: 7903727: Remove the reliance on String Templates feature [v5]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Jun 4 16:31:46 UTC 2024


On Tue, 4 Jun 2024 12:24:46 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove space, to not appear in the diff
>
> src/main/java/org/openjdk/jextract/impl/StructBuilder.java line 315:
> 
>> 313:                 return {0}.asSlice(layout().byteSize() * index);
>> 314:             '}'
>> 315:             """, arrayParam));
> 
> This doesn't look right. The javadoc should not be changed here.

The quoting of the `{` also seems suspicious?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/244#discussion_r1625970832


More information about the jextract-dev mailing list