RFR: 7903727: Remove the reliance on String Templates feature [v5]
Nizar Benalla
nbenalla at openjdk.org
Tue Jun 4 16:31:46 UTC 2024
On Tue, 4 Jun 2024 13:05:26 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> src/main/java/org/openjdk/jextract/impl/StructBuilder.java line 315:
>>
>>> 313: return {0}.asSlice(layout().byteSize() * index);
>>> 314: '}'
>>> 315: """, arrayParam));
>>
>> This doesn't look right. The javadoc should not be changed here.
>
> The quoting of the `{` also seems suspicious?
This was one of the couple of times where I used `MessageFormat`, so I had to escape the `{`
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/244#discussion_r1625974107
More information about the jextract-dev
mailing list