RFR: 7903727: Remove the reliance on String Templates feature [v8]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Jun 5 15:16:13 UTC 2024


On Wed, 5 Jun 2024 14:54:32 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove String::format for simple concatenation
>
> src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 243:
> 
>> 241:     private String primitiveLayoutString(Primitive primitiveType, long align) {
>> 242:         return switch (primitiveType.kind()) {
>> 243:             case Bool -> runtimeHelperName() + ".C_BOOL";
> 
> Tiny change to avoid additional fixes in the future

If you fix these, shouldn't you fix also the other cases in this switch, for consistency?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/244#discussion_r1627974691


More information about the jextract-dev mailing list