RFR: 7903727: Remove the reliance on String Templates feature [v8]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Jun 5 15:16:13 UTC 2024
On Wed, 5 Jun 2024 15:13:23 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java line 243:
>>
>>> 241: private String primitiveLayoutString(Primitive primitiveType, long align) {
>>> 242: return switch (primitiveType.kind()) {
>>> 243: case Bool -> runtimeHelperName() + ".C_BOOL";
>>
>> Tiny change to avoid additional fixes in the future
>
> If you fix these, shouldn't you fix also the other cases in this switch, for consistency?
Ah ok, alignIfNeeded assumes formatting... but, is that a self-inflicted wound?
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/244#discussion_r1627975566
More information about the jextract-dev
mailing list