RFR: 7903758: jextract should avoid temporary file creation [v5]

[Jorn Vernee]

On Tue, 25 Jun 2024 14:25:56 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> jextract creates a temporary file to support multiple headers and special header syntax <foo.h>. This patch avoids that temporary file creation by using clang's in-memory parsing API clang_createTranslationUnitFromSourceFile
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unused Parser.parse overload as suggested in review

src/main/java/org/openjdk/jextract/clang/Index.java line 68:

> 66:         }
> 67: 
> 68:         public ParsingFailedException(String srcFile, ErrorCode code) {

Where is this new constructor being used?

src/main/java/org/openjdk/jextract/clang/Index.java line 119:

> 117: 
> 118: 
> 119:     public TranslationUnit parseTU(String file, Consumer<Diagnostic> dh, int options, String... args)

Can't the methods here that _don't_ take a file content be cleaned up as well now?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/251#discussion_r1652978284
PR Review Comment: https://git.openjdk.org/jextract/pull/251#discussion_r1652979400