RFR: 7903758: jextract should avoid temporary file creation [v5]

Athijegannathan Sundararajan sundar at openjdk.org
Tue Jun 25 15:03:31 UTC 2024


On Tue, 25 Jun 2024 14:48:34 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed unused Parser.parse overload as suggested in review
>
> src/main/java/org/openjdk/jextract/clang/Index.java line 119:
> 
>> 117: 
>> 118: 
>> 119:     public TranslationUnit parseTU(String file, Consumer<Diagnostic> dh, int options, String... args)
> 
> Can't the methods here that _don't_ take a file content be cleaned up as well now?

It was used in macro parser. But with changes in macro parse implementation, these may not be. Will remove.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/251#discussion_r1653000385


More information about the jextract-dev mailing list