RFR: 7903731: Jextract should support macOS frameworks [v3]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Jan 6 11:14:52 UTC 2025
On Mon, 30 Dec 2024 23:55:45 GMT, Marcono1234 <duke at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> use consistent spacing
>
> doc/GUIDE.md line 995:
>
>> 993: | Option | Meaning |
>> 994: |:-----------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
>> 995: | `--mac-framework-dir <dir>` | specify the framework directory dir include files <br/>defaults to the current Mac OS X SDK dir<br/> This removes the need of having a compile_flags.txt with the required `-framework XYZ` options in the folder where jextract is ran |
>
> Is this "directory dir" intentional?
> Suggestion:
>
> | `--mac-framework-dir <dir>` | specify the framework directory include files <br/>defaults to the current Mac OS X SDK dir<br/> This removes the need of having a compile_flags.txt with the required `-framework XYZ` options in the folder where jextract is ran |
I believe I agree with @Marcono1234 - it seems like a typo to me.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1904026433
More information about the jextract-dev
mailing list