RFR: 7903731: Jextract should support macOS frameworks [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jan 6 11:21:49 UTC 2025


On Thu, 2 Jan 2025 19:14:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Read the JBS issue for more detail.
>> 
>> This patch adds two new mac specific options, to make it easier to use frameworks and remove the need of a `compile_flags.txt` file. An exception is thrown if those options are used from an other platform, the error message is inspired from `jpackage`
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use consistent spacing

doc/GUIDE.md line 993:

> 991: **macOS platform options (available only when running on macOS):**
> 992: 
> 993: | Option                       | Meaning                                                                                                                                                                                                                                 |

I'd say let's just add these two options to the list above and maybe put some comment (e.g. MacOS only). If we end up with many platform-specific options we can reconsider of course, but I think there's value in having all the options in the same place.

doc/GUIDE.md line 995:

> 993: | Option                       | Meaning                                                                                                                                                                                                                                 |
> 994: |:-----------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
> 995: | `--mac-framework-dir <dir>`  | specify the framework directory dir include files <br/>defaults to the current Mac OS X SDK dir<br/> This removes the need of having a compile_flags.txt with the required `-framework XYZ` options in the folder where jextract is ran |

Maybe we could call this `macos-framework-dir` ?

src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties line 90:

> 88: --version                          print version information and exit                           \n
> 89: 
> 90: jextract.usage.mac=\

Again, not sure it's worth splitting the list of options in two.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1904029614
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1904030146
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1904032364


More information about the jextract-dev mailing list