RFR: 7903731: Jextract should support macOS frameworks [v4]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Mar 5 12:39:07 UTC 2025
On Wed, 5 Mar 2025 10:29:28 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>>
>> - Respond to feedback, Update Guide
>> - Merge branch 'refs/heads/master' into jextract-mac-os
>>
>> # Conflicts:
>> # src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties
>> - Merge remote-tracking branch 'upstream/master' into jextract-mac-os
>> - use consistent spacing
>> - Fix typos, rename some methods and bump copyright year to 2025
>> - add mac os support
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 364:
>
>> 362: parser.accepts("--version", "help.version", false);
>> 363: parser.accepts("--macos-framework", "help.mac.framework", true);
>> 364: parser.accepts("-f", "help.framework.library.path", true);
>
> In clang these are named `-F` and `-framework` [1] (there's no `-f`). I think we should just match that. We did the same for `-D`, `-I` and `-l` to an extent.
>
> [1]: https://clang.llvm.org/docs/ClangCommandLineReference.html
I mean -- if one has a prefix `macos-` the other should too -- or none should have it.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1981319907
More information about the jextract-dev
mailing list