RFR: 7903731: Jextract should support macOS frameworks [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Mar 5 12:42:06 UTC 2025


On Wed, 5 Mar 2025 12:36:26 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/main/java/org/openjdk/jextract/JextractTool.java line 364:
>> 
>>> 362:         parser.accepts("--version", "help.version", false);
>>> 363:         parser.accepts("--macos-framework", "help.mac.framework", true);
>>> 364:         parser.accepts("-f", "help.framework.library.path", true);
>> 
>> In clang these are named `-F` and `-framework` [1] (there's no `-f`). I think we should just match that. We did the same for `-D`, `-I` and `-l` to an extent.
>> 
>> [1]: https://clang.llvm.org/docs/ClangCommandLineReference.html
>
> I mean -- if one has a prefix `macos-` the other should too -- or none should have it.

Also, `-f` usually is used in conjunction with other options e.g. `-fmove-loop-invariants`. Which is probably the reason behind the capital letter `-F`.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1981323989


More information about the jextract-dev mailing list