RFR: 7903731: Jextract should support macOS frameworks [v6]

Nizar Benalla nbenalla at openjdk.org
Wed Mar 5 17:04:23 UTC 2025


On Wed, 5 Mar 2025 16:19:37 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   -search custom framework dirs
>>   -rename options
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 623:
> 
>> 621: 
>> 622:         String publicPath = String.format("/System/Library/Frameworks/%1$s.framework/", optionString);
>> 623:         String privatePath = String.format("/System/Library/PrivateFrameworks/%1$s.framework/", optionString);
> 
> Also, shouldn't this default just use the result of `inferMacOSFrameworkPath`?

Sure, note that the result of `inferMacOSFrameworkPath ` is checked before as it was added to `frameworkDirs`.
The path would still be incorrect but maybe it's better than a malformed path.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1981819319


More information about the jextract-dev mailing list