RFR: 7903731: Jextract should support macOS frameworks [v6]
Nizar Benalla
nbenalla at openjdk.org
Thu Mar 6 14:04:21 UTC 2025
On Wed, 5 Mar 2025 16:21:16 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> -search custom framework dirs
>> -rename options
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 396:
>
>> 394: Files.lines(compileFlagsTxt).forEach(opt -> {
>> 395: builder.addClangArg(opt);
>> 396: frameworkDirs.add(opt.substring(2).trim());
>
> Compile flags can also contain other flags, so we have to explicitly look for `-F` options here for this to work.
>
> But, I'd also be okay just ignoring the `-F` flags in `compile_flags`. We can tell people to use the builtin `-F`.
I chose to ignore the `-F` flags in `compile_flags`.
The paths passed using the builtin `-F` will be checked first before public/private paths and the MacOs SDK, that way there are "good" defaults and it's simple enough for users to override them
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1983406571
More information about the jextract-dev
mailing list