RFR: 7903731: Jextract should support macOS frameworks [v7]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Mar 6 15:04:08 UTC 2025


On Wed, 5 Mar 2025 17:38:49 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Read the JBS issue for more detail.
>> 
>> This patch adds two new mac specific options, to make it easier to use frameworks and remove the need of a `compile_flags.txt` file. An exception is thrown if those options are used from an other platform, the error message is inspired from `jpackage`
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   inverse -framework and -F

src/main/java/org/openjdk/jextract/JextractTool.java line 609:

> 607: 
> 608:     private String formatFrameworkPath(String optionString) {
> 609:         for (String dir : frameworkDirs) {

It still feels like this code can be made more regular by keeping a list of framework paths in this class, then prepending new paths (the ones added with `-framework`) and then scanning the list and returning the first match.

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1983518830


More information about the jextract-dev mailing list