RFR: 7903731: Jextract should support macOS frameworks [v7]
Nizar Benalla
nbenalla at openjdk.org
Fri Mar 7 15:41:17 UTC 2025
On Thu, 6 Mar 2025 15:01:35 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> inverse -framework and -F
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 609:
>
>> 607:
>> 608: private String formatFrameworkPath(String optionString) {
>> 609: for (String dir : frameworkDirs) {
>
> It still feels like this code can be made more regular by keeping a list of framework paths in this class, then prepending new paths (the ones added with `-framework`) and then scanning the list and returning the first match.
I've made a small update to achieve this. Also moved the code the handle the `-F` options to be higher as we need to add those paths to the list before we can resolve the framework paths. (I missed this before)
I've renamed some variables/methods to be more accurate, as the previous name was a bit misleading.
-------------
PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1985279135
More information about the jextract-dev
mailing list