RFR: 7903731: Jextract should support macOS frameworks [v10]

[Maurizio Cimadamore]

On Fri, 7 Mar 2025 18:02:25 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renaming variable to be more accurate
>
> src/main/java/org/openjdk/jextract/JextractTool.java line 539:
> 
>> 537:             for (String lib : optionSet.valuesOf("-" + optionString)) {
>> 538:                 try {
>> 539:                     lib = optionString.equals("framework") ?
> 
> Is the argument of `framework` always a relative path? Or does macos also allow absolute paths to be used? In that case, should be check for something that starts with `/` ?

gaaaah - got confused -- `-framework` is a framework name. In that case, the code is good (and better than before, thanks!). But the exception seems misleading. It should say something like `Cannot resolve/find framework <name>`, rather than speaking about paths?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1985479718