RFR: 7903731: Jextract should support macOS frameworks [v10]

Nizar Benalla nbenalla at openjdk.org
Fri Mar 7 18:30:28 UTC 2025


On Fri, 7 Mar 2025 18:05:58 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/main/java/org/openjdk/jextract/JextractTool.java line 539:
>> 
>>> 537:             for (String lib : optionSet.valuesOf("-" + optionString)) {
>>> 538:                 try {
>>> 539:                     lib = optionString.equals("framework") ?
>> 
>> Is the argument of `framework` always a relative path? Or does macos also allow absolute paths to be used? In that case, should be check for something that starts with `/` ?
>
> gaaaah - got confused -- `-framework` is a framework name. In that case, the code is good (and better than before, thanks!). But the exception seems misleading. It should say something like `Cannot resolve/find framework <name>`, rather than speaking about paths?

Updated the error message, the user should see `error: cannot find framework for -framework option: NAME`

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1985509842


More information about the jextract-dev mailing list