RFR: 7903731: Jextract should support macOS frameworks [v11]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Mar 7 18:49:10 UTC 2025


On Fri, 7 Mar 2025 18:30:27 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Read the JBS issue for more detail.
>> 
>> This patch adds two new mac specific options, to make it easier to use frameworks and remove the need of a `compile_flags.txt` file. An exception is thrown if those options are used from an other platform, the error message is inspired from `jpackage`
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improve error message

src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties line 29:

> 27: not.a.file=not a file: {0}
> 28: l.option.value.invalid=invalid library specifier for -l option: {0}
> 29: framework.option.value.invalid=cannot find framework for -framework option: {0}

I suggest to just say `Cannot find framework {0}`. Adding `for framework option` doesn't seem too useful?

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1985537043


More information about the jextract-dev mailing list