RFR: 7903731: Jextract should support macOS frameworks [v11]

Nizar Benalla nbenalla at openjdk.org
Fri Mar 7 19:43:47 UTC 2025


On Fri, 7 Mar 2025 18:46:14 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve error message
>
> src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties line 29:
> 
>> 27: not.a.file=not a file: {0}
>> 28: l.option.value.invalid=invalid library specifier for -l option: {0}
>> 29: framework.option.value.invalid=cannot find framework for -framework option: {0}
> 
> I suggest to just say `Cannot find framework {0}`. Adding `for framework option` doesn't seem too useful?

Sure, I admit it's redundant information

-------------

PR Review Comment: https://git.openjdk.org/jextract/pull/268#discussion_r1985594217


More information about the jextract-dev mailing list