[for review] 6948144: jpkg throws NPE if resource directory does not exist

Alan Bateman Alan.Bateman at oracle.com
Thu Apr 29 07:02:59 PDT 2010


Dalibor Topic wrote:
> Hi Alan,
>
> thanks for reporting a NPE with
> $ jpkg -m existing-dir -r non-existing-dir jmod some-mod
>
> the fix is easy - test whether the resource path exists before passing
> it on to module file writer ;) The webrev is at
> http://cr.openjdk.java.net/~robilad/6948144/webrev.00/
>
> Once this one is in, I'll commit similar tests for the remaining parameters.
>
> cheers,
> dalibor topic
>   
The fix looks OK to me. I'm not sure about the name of the test though 
as it doesn't seem to be consistent with the other tests. In time it can 
be useful to expand existing tests with additional tests.

-Alan.



More information about the jigsaw-dev mailing list